feat: enhance peer neighbor handling by introducing NormalizePeerNeighborString function. Update CreatePeer and UpdatePeer methods in Postgres and Memory stores to validate and normalize neighbor input, improving data integrity and error handling.

2026-04-06 01:01:40 +07:00
parent d92a06c9c8
commit 80f3a8d105
5 changed files with 96 additions and 12 deletions
@@ -315,6 +315,10 @@ func (p *Postgres) CreatePeer(tenantID string, in *store.BGPPeer) (*store.BGPPee
 	if in == nil || in.RemoteASN == 0 {
 		return nil, store.ErrInvalidInput
 	}
+	neighbor, ok := store.NormalizePeerNeighborString(in.Neighbor)
+	if !ok {
+		return nil, store.ErrInvalidInput
+	}
 	ctx := context.Background()
 	id := uuid.NewString()
 	meta := map[string]any{"name": in.Name, "session_state": in.SessionState}
@@ -330,7 +334,7 @@ func (p *Postgres) CreatePeer(tenantID string, in *store.BGPPeer) (*store.BGPPee
 	_, err := p.pool.Exec(ctx, `
 		INSERT INTO bgp_peer (id, tenant_id, bgp_speaker_id, neighbor, remote_asn, enabled, policies_json, meta_json)
 		VALUES ($1,$2,$3,$4::inet, $5, $6, $7::jsonb, $8::jsonb)`,
-		id, tenantID, sp, in.Neighbor, in.RemoteASN, in.Enabled, pol, string(mb))
+		id, tenantID, sp, neighbor, in.RemoteASN, in.Enabled, pol, string(mb))
 	if err != nil {
 		return nil, err
 	}
@@ -343,7 +347,11 @@ func (p *Postgres) UpdatePeer(tenantID, id string, patch *store.PeerPatch) (*sto
 		return nil, err
 	}
 	if patch.Neighbor != nil {
-		cur.Neighbor = strings.TrimSpace(*patch.Neighbor)
+		n, ok := store.NormalizePeerNeighborString(*patch.Neighbor)
+		if !ok {
+			return nil, store.ErrInvalidInput
+		}
+		cur.Neighbor = n
 	}
 	if patch.RemoteASN != nil {
 		cur.RemoteASN = *patch.RemoteASN