From e0a912a6934c95a38c8ed2986835ec38757228bd Mon Sep 17 00:00:00 2001 From: Denozordec Date: Thu, 21 May 2026 13:21:33 +0700 Subject: [PATCH] fix(worker): ensure job success is called before enqueueing deploy speakers - Moved the call to j.Succeed() to occur before enqueueing deploy speakers in the runPeerReconcile and finishModuleRefreshSuccess methods, ensuring proper job success handling. --- internal/jobs/worker.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/internal/jobs/worker.go b/internal/jobs/worker.go index 66af8b2..38872ba 100644 --- a/internal/jobs/worker.go +++ b/internal/jobs/worker.go @@ -219,8 +219,8 @@ func (w *Worker) runPeerReconcile(j *Job) { } else { j.mergeMeta(map[string]any{"log_build_error": err.Error()}) } - j.Succeed() w.enqueueDeployAllSpeakers(j, j.TenantID, revID) + j.Succeed() } func (w *Worker) peerTriggerModuleID(tenantID string, latest []*store.Revision) (string, error) { @@ -346,8 +346,8 @@ func (w *Worker) finishModuleRefreshSuccess(j *Job, triggerModuleID string) { } else { j.mergeMeta(map[string]any{"log_build_error": err.Error()}) } - j.Succeed() w.enqueueDeployAllSpeakers(j, j.TenantID, rev) + j.Succeed() } // enqueueDeployAllSpeakers queues the same work as POST /v1/apply (all speakers, no speaker_id).