IKEv1 XAuth: Adding "initiate" flag parameter to the initiate_xauth method, signalling whether or not to call the task_manager->initiate method after queueing the task.

src/libcharon/processing/jobs/initiate_xauth_job.c

@@ -52,8 +52,7 @@ METHOD(job_t, initiate, void,
 												   this->ike_sa_id);
 	if (ike_sa)
 	{
-		DBG1(DBG_IKE, "INITIATING XAUTH!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!");
+		ike_sa->initiate_xauth(ike_sa, TRUE);
-		ike_sa->initiate_xauth(ike_sa);
 		charon->ike_sa_manager->checkin(charon->ike_sa_manager, ike_sa);
 	}
 	destroy(this);

src/libcharon/sa/ike_sa.c

@@ -1019,11 +1019,15 @@ METHOD(ike_sa_t, initiate_mediated, status_t,
 #endif /* ME */
 
 METHOD(ike_sa_t, initiate_xauth, status_t,
-	private_ike_sa_t *this)
+	private_ike_sa_t *this, bool initiate)
 {
 	xauth_request_t *task = xauth_request_create(&this->public, TRUE);
 	this->task_manager->queue_task(this->task_manager, (task_t*)task);
-	return this->task_manager->initiate(this->task_manager);
+	if(initiate)
+	{
+		return this->task_manager->initiate(this->task_manager);
+	}
+	return SUCCESS;
 }
 
 /**

src/libcharon/sa/ike_sa.h

@@ -970,7 +970,7 @@ struct ike_sa_t {
 	/**
 	 * Initiate an XAuth authentication exchange.
 	 */
-	status_t (*initiate_xauth) (ike_sa_t *this);
+	status_t (*initiate_xauth) (ike_sa_t *this, bool initiate);
 };
 
 /**