denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check return value of asprintf(3) when converting AR identity

Browse Source 
Using chunk_t.ptr as target was also not optimal as it resulted in
a compiler warning.
This commit is contained in:
Tobias Brunner
2013-03-22 11:34:16 +01:00
parent 753e0a0099
commit 03237238b8
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/plugins/tnc_tnccs/tnc_tnccs_manager.c
+4 -2
View File
@@ -719,6 +719,7 @@ METHOD(tnccs_manager_t, get_attribute, TNC_Result,
tncif_identity_t *tnc_id; tncif_identity_t *tnc_id;
u_int32_t id_type, subject_type; u_int32_t id_type, subject_type;
chunk_t id_value; chunk_t id_value;
char *id_str;
TNC_Result result; TNC_Result result;
list = linked_list_create(); list = linked_list_create();
@@ -752,9 +753,10 @@ METHOD(tnccs_manager_t, get_attribute, TNC_Result,
id_type = TNC_ID_UNKNOWN; id_type = TNC_ID_UNKNOWN;
subject_type = TNC_SUBJECT_UNKNOWN; subject_type = TNC_SUBJECT_UNKNOWN;
} }
if (id_type != TNC_ID_UNKNOWN) if (id_type != TNC_ID_UNKNOWN &&
asprintf(&id_str, "%Y", peer) >= 0)
{ {
id_value.len = asprintf(&id_value.ptr, "%Y", peer); id_value = chunk_from_str(id_str);
tnc_id = tncif_identity_create( tnc_id = tncif_identity_create(
pen_type_create(PEN_TCG, id_type), id_value, pen_type_create(PEN_TCG, id_type), id_value,
pen_type_create(PEN_TCG, subject_type), pen_type_create(PEN_TCG, subject_type),