backtrace: Remove name checks after SymFromAddr() calls

The Name member is an array whose address is always defined.
This commit is contained in:
Tobias Brunner
2014-07-02 12:11:59 +02:00
parent fbe462e1b0
commit 0e48f67562
+1 -5
View File
@@ -492,8 +492,7 @@ METHOD(backtrace_t, log_, void,
if (module && GetModuleFileName(module, filename, sizeof(filename)))
{
if (SymFromAddr(process, frame, &displace, &symbol.hdr) &&
symbol.hdr.Name)
if (SymFromAddr(process, frame, &displace, &symbol.hdr))
{
println(file, " %s%s%s @ %p (%s%s%s+0x%tx) [%p]",
esc(file, TTY_FG_YELLOW), filename,
@@ -614,8 +613,6 @@ METHOD(backtrace_t, contains_function, bool,
symbol.hdr.MaxNameLen = sizeof(symbol.buf) - 1;
if (SymFromAddr(process, (DWORD64)this->frames[i], NULL, &symbol.hdr))
{
if (symbol.hdr.Name)
{
for (j = 0; j < count; j++)
{
@@ -627,7 +624,6 @@ METHOD(backtrace_t, contains_function, bool,
}
}
}
}
dbghelp_mutex->unlock(dbghelp_mutex);
#endif /* HAVE_DLADDR/HAVE_DBGHELP */