denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

imv-os-agent: Remove useless assignment

Browse Source 
`eval` will never be TNC_IMV_EVALUATION_RESULT_DONT_KNOW so we can
remove the if statement too.
This commit is contained in:
Tobias Brunner
2018-09-17 18:51:42 +02:00
parent ddc797686f
commit 1295558ab3
1 changed files with 9 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libimcv/plugins/imv_os/imv_os_agent.c
+9 -13
View File
@@ -539,7 +539,7 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
/* Determine maximum PA-TNC attribute segment size */ /* Determine maximum PA-TNC attribute segment size */
max_seg_size = state->get_max_msg_len(state) max_seg_size = state->get_max_msg_len(state)
- PA_TNC_HEADER_SIZE - PA_TNC_HEADER_SIZE
- PA_TNC_ATTR_HEADER_SIZE - PA_TNC_ATTR_HEADER_SIZE
- TCG_SEG_ATTR_SEG_ENV_HEADER; - TCG_SEG_ATTR_SEG_ENV_HEADER;
@@ -614,7 +614,7 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
if (result != TNC_RESULT_SUCCESS) if (result != TNC_RESULT_SUCCESS)
{ {
return result; return result;
} }
return this->agent->provide_recommendation(this->agent, state); return this->agent->provide_recommendation(this->agent, state);
} }
else else
@@ -686,7 +686,6 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
{ {
continue; continue;
} }
eval = TNC_IMV_EVALUATION_RESULT_DONT_KNOW;
switch (workitem->get_type(workitem)) switch (workitem->get_type(workitem))
{ {
@@ -721,7 +720,7 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
TNC_IMV_EVALUATION_RESULT_COMPLIANT; TNC_IMV_EVALUATION_RESULT_COMPLIANT;
snprintf(result_str, BUF_LEN, "unknown sources%s enabled", snprintf(result_str, BUF_LEN, "unknown sources%s enabled",
fail ? "" : " not"); fail ? "" : " not");
break; break;
case IMV_WORKITEM_FORWARDING: case IMV_WORKITEM_FORWARDING:
if (!(received & IMV_OS_ATTR_FORWARDING_ENABLED)) if (!(received & IMV_OS_ATTR_FORWARDING_ENABLED))
{ {
@@ -749,14 +748,11 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
default: default:
continue; continue;
} }
if (eval != TNC_IMV_EVALUATION_RESULT_DONT_KNOW) session->remove_workitem(session, enumerator);
{ rec = workitem->set_result(workitem, result_str, eval);
session->remove_workitem(session, enumerator); state->update_recommendation(state, rec, eval);
rec = workitem->set_result(workitem, result_str, eval); imcv_db->finalize_workitem(imcv_db, workitem);
state->update_recommendation(state, rec, eval); workitem->destroy(workitem);
imcv_db->finalize_workitem(imcv_db, workitem);
workitem->destroy(workitem);
}
} }
enumerator->destroy(enumerator); enumerator->destroy(enumerator);
@@ -772,7 +768,7 @@ METHOD(imv_agent_if_t, batch_ending, TNC_Result,
return result; return result;
} }
return this->agent->provide_recommendation(this->agent, state); return this->agent->provide_recommendation(this->agent, state);
} }
} }
/* send non-empty PA-TNC message with excl flag not set */ /* send non-empty PA-TNC message with excl flag not set */