denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fips-prf: Add explicit bound check to avoid GCC 12 compile warning

Browse Source 
GCC assumes this->b is zero (or may be zero) and spits out the following
warning (or error with -Werror):

src/libstrongswan/plugins/fips_prf/fips_prf.c:124:12: error: array subscript 18446744073709551615 is above array bounds of ‘uint8_t[<U8090>]’ {aka ‘unsigned char[<U8090>]’} [-Werror=array-bounds]
  124 |         one[this->b - 1] = 0x01;
      |         ~~~^~~~~~~~~~~~~
This commit is contained in:
Tobias Brunner
2022-06-27 14:09:11 +02:00
parent 585666aa97
commit 1c198bf22b
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libstrongswan/plugins/fips_prf/fips_prf.c
+2 -2
View File
@@ -114,9 +114,9 @@ METHOD(prf_t, get_bytes, bool,
uint8_t *xkey = this->key; uint8_t *xkey = this->key;
uint8_t one[this->b]; uint8_t one[this->b];
if (!w) if (!w || !this->b)
{ {
/* append mode is not supported */ /* append mode is not supported, the other check is to make GCC happy */
return FALSE; return FALSE;
} }