chunk: Use dynamically allocated buffer in chunk_from_fd()

When acting on files, we can use fstat() to estimate the buffer size. On
non-file FDs, we dynamically increase an allocated buffer.

Additionally we slightly change the function signature to properly handle
zero-length files and add appropriate unit tests.
This commit is contained in:
Martin Willi
2014-01-23 15:55:32 +01:00
parent 595b6d9a82
commit 1c4a3459f7
10 changed files with 183 additions and 25 deletions
+7 -1
View File
@@ -14,6 +14,7 @@
*/
#include <time.h>
#include <errno.h>
#include "pki.h"
@@ -273,7 +274,12 @@ static int self()
{
chunk_t chunk;
chunk = chunk_from_fd(0);
if (!chunk_from_fd(0, &chunk))
{
fprintf(stderr, "%s: ", strerror(errno));
error = "reading private key failed";
goto end;
}
private = lib->creds->create(lib->creds, CRED_PRIVATE_KEY, type,
BUILD_BLOB, chunk, BUILD_END);
free(chunk.ptr);