denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Check rng return value when generating DH secret in gcrypt plugin

Browse Source
This commit is contained in:
Tobias Brunner
2012-07-16 14:53:36 +02:00
committed by Martin Willi
parent 5025135f70
commit 1f5291b1ce
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libstrongswan/plugins/gcrypt/gcrypt_dh.c
+2 -2
View File
@@ -208,9 +208,8 @@ gcrypt_dh_t *create_generic(diffie_hellman_group_t group, size_t exp_len,
} }
rng = lib->crypto->create_rng(lib->crypto, RNG_STRONG); rng = lib->crypto->create_rng(lib->crypto, RNG_STRONG);
if (rng) if (rng && rng->allocate_bytes(rng, exp_len, &random))
{ /* prefer external randomizer */ { /* prefer external randomizer */
rng->allocate_bytes(rng, exp_len, &random);
rng->destroy(rng); rng->destroy(rng);
err = gcry_mpi_scan(&this->xa, GCRYMPI_FMT_USG, err = gcry_mpi_scan(&this->xa, GCRYMPI_FMT_USG,
random.ptr, random.len, NULL); random.ptr, random.len, NULL);
@@ -226,6 +225,7 @@ gcrypt_dh_t *create_generic(diffie_hellman_group_t group, size_t exp_len,
} }
else else
{ /* fallback to gcrypt internal randomizer, shouldn't ever happen */ { /* fallback to gcrypt internal randomizer, shouldn't ever happen */
DESTROY_IF(rng);
this->xa = gcry_mpi_new(exp_len * 8); this->xa = gcry_mpi_new(exp_len * 8);
gcry_mpi_randomize(this->xa, exp_len * 8, GCRY_STRONG_RANDOM); gcry_mpi_randomize(this->xa, exp_len * 8, GCRY_STRONG_RANDOM);
} }