denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

plugin-loader: Do not unload libraries during dlclose(), if supported

Browse Source 
Unloading libraries calls any library constructor/destructor functions. Some
libraries can't handle that in our excessive unit test use. GnuTLS leaks
a /dev/urandom file descriptor, letting unit tests fail with arbitrary
out-of-resources errors.
This commit is contained in:
Martin Willi
2015-02-24 12:25:01 +01:00
parent 67a9744bb9
commit 20a0fd9255
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libstrongswan/plugins/plugin_loader.c
+9 -1
View File
@@ -380,7 +380,15 @@ static plugin_entry_t *load_plugin(private_plugin_loader_t *this, char *name,
return NULL; return NULL;
} }
} }
handle = dlopen(file, RTLD_LAZY); handle = dlopen(file, RTLD_LAZY
#ifdef RTLD_NODELETE
/* if supported, do not unload library when unloading a plugin. It really
* doesn't matter in productive systems, but causes many (dependency)
* library reloads during unit tests. Some libraries can't handle that,
* GnuTLS leaks file descriptors in its library load/unload functions. */
| RTLD_NODELETE
#endif
);
if (handle == NULL) if (handle == NULL)
{ {
DBG1(DBG_LIB, "plugin '%s' failed to load: %s", name, dlerror()); DBG1(DBG_LIB, "plugin '%s' failed to load: %s", name, dlerror());