Properly hash pointers for hash tables where appropriate

Simply using the pointer is not optimal for our hash table
implementation, which simply masks the key to determine the bucket.
This commit is contained in:
Tobias Brunner
2014-03-31 14:32:44 +02:00
parent 7522fcffd2
commit 3b09c02ec0
4 changed files with 7 additions and 71 deletions
+2 -17
View File
@@ -94,22 +94,6 @@ bool cred_encoding_args(va_list args, ...)
return !failed;
}
/**
* hashtable hash() function
*/
static u_int hash(void *key)
{
return (uintptr_t)key;
}
/**
* hashtable equals() function
*/
static bool equals(void *key1, void *key2)
{
return key1 == key2;
}
METHOD(cred_encoding_t, get_cache, bool,
private_cred_encoding_t *this, cred_encoding_type_t type, void *cache,
chunk_t *encoding)
@@ -289,7 +273,8 @@ cred_encoding_t *cred_encoding_create()
for (type = 0; type < CRED_ENCODING_MAX; type++)
{
this->cache[type] = hashtable_create(hash, equals, 8);
this->cache[type] = hashtable_create(hashtable_hash_ptr,
hashtable_equals_ptr, 8);
}
return &this->public;