Move establish/inherit of rekeyed IKE_SAs to delete messages
Having the inherit() function delayed to the IKE_SA establish procedure was problematic. The task destroy function was never a good place and results in locking/cleanup problems. After establishing the SA, it should be really checked in ASAP to avoid any triggered DPD checks to get lost.
This commit is contained in:
@@ -912,9 +912,8 @@ struct ike_sa_t {
|
||||
* As this call may initiate inherited tasks, a status is returned.
|
||||
*
|
||||
* @param other other task to inherit from
|
||||
* @return DESTROY_ME if initiation of inherited task failed
|
||||
*/
|
||||
status_t (*inherit) (ike_sa_t *this, ike_sa_t *other);
|
||||
void (*inherit) (ike_sa_t *this, ike_sa_t *other);
|
||||
|
||||
/**
|
||||
* Reset the IKE_SA, useable when initiating fails
|
||||
|
||||
Reference in New Issue
Block a user