settings: strongswan.conf must be loaded explicitly

src/libstrongswan/library.c

@@ -298,6 +298,13 @@ bool library_init(char *settings, const char *namespace)
 
 	this->objects = hashtable_create((hashtable_hash_t)hash,
 									 (hashtable_equals_t)equals, 4);
+
+#ifdef STRONGSWAN_CONF
+	if (!settings)
+	{
+		settings = STRONGSWAN_CONF;
+	}
+#endif
 	this->public.settings = settings_create(settings);
 	/* all namespace settings may fall back to libstrongswan */
 	lib->settings->add_fallback(lib->settings, lib->ns, "libstrongswan");

src/libstrongswan/settings/settings.c

@@ -839,13 +839,9 @@ static bool load_files_internal(private_settings_t *this, section_t *parent,
 {
 	section_t *section;
 
-	if (pattern == NULL)
-	{
-#ifdef STRONGSWAN_CONF
-		pattern = STRONGSWAN_CONF;
-#else
+	if (pattern == NULL || !pattern[0])
+	{	/* TODO: Clear parent if merge is FALSE? */
 		return FALSE;
-#endif
 	}
 
 	section = settings_section_create(NULL);

src/libstrongswan/settings/settings.h

@@ -343,7 +343,9 @@ struct settings_t {
 /**
  * Load settings from a file.
  *
- * @param file			file to read settings from, NULL for default
+ * @note If parsing the file fails the object is still created.
+ *
+ * @param file			optional file to read settings from
  * @return				settings object
  */
 settings_t *settings_create(char *file);