denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

receiver: Properly clean up if hasher or RNG can't be created

Browse Source
This commit is contained in:
Tobias Brunner
2025-03-04 15:30:25 +01:00
parent 380ec66c92
commit 4e2cf58961
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/network/receiver.c
+4 -5
View File
@@ -656,8 +656,8 @@ METHOD(receiver_t, del_esp_cb, void,
METHOD(receiver_t, destroy, void, METHOD(receiver_t, destroy, void,
private_receiver_t *this) private_receiver_t *this)
{ {
this->rng->destroy(this->rng); DESTROY_IF(this->rng);
this->hasher->destroy(this->hasher); DESTROY_IF(this->hasher);
this->esp_cb_mutex->destroy(this->esp_cb_mutex); this->esp_cb_mutex->destroy(this->esp_cb_mutex);
free(this); free(this);
} }
@@ -717,15 +717,14 @@ receiver_t *receiver_create()
if (!this->hasher) if (!this->hasher)
{ {
DBG1(DBG_NET, "creating cookie hasher failed, no hashers supported"); DBG1(DBG_NET, "creating cookie hasher failed, no hashers supported");
free(this); destroy(this);
return NULL; return NULL;
} }
this->rng = lib->crypto->create_rng(lib->crypto, RNG_STRONG); this->rng = lib->crypto->create_rng(lib->crypto, RNG_STRONG);
if (!this->rng) if (!this->rng)
{ {
DBG1(DBG_NET, "creating cookie RNG failed, no RNG supported"); DBG1(DBG_NET, "creating cookie RNG failed, no RNG supported");
this->hasher->destroy(this->hasher); destroy(this);
free(this);
return NULL; return NULL;
} }
if (!this->rng->get_bytes(this->rng, SECRET_LENGTH, this->secret)) if (!this->rng->get_bytes(this->rng, SECRET_LENGTH, this->secret))