denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ensure that pipe is closed when calling resolvconf(8)

Browse Source
This commit is contained in:
Tobias Brunner
2012-09-28 17:33:24 +02:00
parent a067dfbb2c
commit 53ab3c27cd
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libhydra/plugins/resolve/resolve_handler.c
+4 -2
View File
@@ -150,6 +150,7 @@ static bool invoke_resolvconf(private_resolve_handler_t *this,
bool install) bool install)
{ {
char cmd[128]; char cmd[128];
bool success = TRUE;
/* we use the nameserver's IP address as part of the interface name to /* we use the nameserver's IP address as part of the interface name to
* make them unique */ * make them unique */
@@ -171,7 +172,8 @@ static bool invoke_resolvconf(private_resolve_handler_t *this,
DBG1(DBG_IKE, "installing DNS server %H via resolvconf", addr); DBG1(DBG_IKE, "installing DNS server %H via resolvconf", addr);
fprintf(out, "nameserver %H # by strongSwan, from %Y\n", addr, fprintf(out, "nameserver %H # by strongSwan, from %Y\n", addr,
server); server);
if (ferror(out) || pclose(out)) success = !ferror(out);
if (pclose(out))
{ {
return FALSE; return FALSE;
} }
@@ -180,7 +182,7 @@ static bool invoke_resolvconf(private_resolve_handler_t *this,
{ {
ignore_result(system(cmd)); ignore_result(system(cmd));
} }
return TRUE; return success;
} }
METHOD(attribute_handler_t, handle, bool, METHOD(attribute_handler_t, handle, bool,