denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixed a certinfo_t memory leak in verify()

Browse Source
This commit is contained in:
Andreas Steffen
2007-03-09 14:59:28 +00:00
parent d45d2f1e21
commit 5455cf230f
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/charon/config/credentials/local_credential_store.c
+4 -1
View File
@@ -621,7 +621,7 @@ static bool verify(private_local_credential_store_t *this, x509_t *cert, bool *f
} }
/* first check certificate revocation using ocsp */ /* first check certificate revocation using ocsp */
status = issuer->verify_by_ocsp(issuer, cert, certinfo, &this->public); status = issuer->verify_by_ocsp(issuer, cert, certinfo, &this->public.credential_store);
/* if ocsp service is not available then fall back to crl */ /* if ocsp service is not available then fall back to crl */
if ((status == CERT_UNDEFINED) || (status == CERT_UNKNOWN && this->strict)) if ((status == CERT_UNDEFINED) || (status == CERT_UNKNOWN && this->strict))
@@ -642,6 +642,7 @@ static bool verify(private_local_credential_store_t *this, x509_t *cert, bool *f
if (this->strict && nextUpdate < time(NULL)) if (this->strict && nextUpdate < time(NULL))
{ {
DBG2(DBG_CFG, "certificate is good but status is stale"); DBG2(DBG_CFG, "certificate is good but status is stale");
certinfo->destroy(certinfo);
return FALSE; return FALSE;
} }
DBG2(DBG_CFG, "certificate is good"); DBG2(DBG_CFG, "certificate is good");
@@ -677,6 +678,7 @@ static bool verify(private_local_credential_store_t *this, x509_t *cert, bool *f
certinfo->get_revocationTime(certinfo)); certinfo->get_revocationTime(certinfo));
} }
} }
certinfo->destroy(certinfo);
return FALSE; return FALSE;
} }
case CERT_UNKNOWN: case CERT_UNKNOWN:
@@ -690,6 +692,7 @@ static bool verify(private_local_credential_store_t *this, x509_t *cert, bool *f
{ {
cert_copy->set_status(cert_copy, CERT_UNTRUSTED); cert_copy->set_status(cert_copy, CERT_UNTRUSTED);
} }
certinfo->destroy(certinfo);
return FALSE; return FALSE;
} }
break; break;