denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ike-sa: Fix handling of redirects during IKE_AUTH

Browse Source 
Since the referenced commit, the state switch to IKE_ESTABLISHED doesn't
happen immediately after completing the authentication but only after
the remaining tasks have finished.  Due to that redirects during IKE_AUTH
were treated like those during IKE_SA_INIT causing the IKE_SA and task
manager to get reset.  However, unlike the ike-init task, the ike-auth
task returned SUCCESS and, therefore, got destroyed, while a different
task was removed from the array that was modified during the reset.
This later caused a dereference of the freed ike-auth task and a crash.

Fixes: 5ce1c91b58 ("ikev2: Trigger ike_updown() event after all IKE-specific tasks ran")
This commit is contained in:
Tobias Brunner
2023-11-06 10:41:57 +01:00
parent 46c012b664
commit 595fa077b6
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/sa/ike_sa.c
+5 -1
View File
@@ -2380,7 +2380,11 @@ METHOD(ike_sa_t, handle_redirect, bool,
switch (this->state) switch (this->state)
{ {
case IKE_CONNECTING: case IKE_CONNECTING:
return redirect_connecting(this, gateway); if (!has_condition(this, COND_AUTHENTICATED))
{
return redirect_connecting(this, gateway);
}
/* fall-through during IKE_AUTH if authenticated */
case IKE_ESTABLISHED: case IKE_ESTABLISHED:
return redirect_established(this, gateway); return redirect_established(this, gateway);
default: default: