denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

child-rekey: Remove redundant migrate() call for child-create sub-task

Browse Source 
When retrying due to a DH group mismatch this is already done by the
child-create task itself.  And in other cases where the task returns
NEED_MORE we actually will need access to a possible proposal to properly
delete it.
This commit is contained in:
Tobias Brunner
2015-08-21 16:14:07 +02:00
parent 1729df9275
commit 70c5f1d40d
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/sa/ikev2/tasks/child_rekey.c
+1 -2
View File
@@ -334,8 +334,7 @@ METHOD(task_t, process_i, status_t,
if (this->child_create->task.process(&this->child_create->task, if (this->child_create->task.process(&this->child_create->task,
message) == NEED_MORE) message) == NEED_MORE)
{ {
/* bad DH group while rekeying, try again */ /* bad DH group while rekeying, retry, or failure requiring deletion */
this->child_create->task.migrate(&this->child_create->task, this->ike_sa);
return NEED_MORE; return NEED_MORE;
} }
if (message->get_payload(message, PLV2_SECURITY_ASSOCIATION) == NULL) if (message->get_payload(message, PLV2_SECURITY_ASSOCIATION) == NULL)