denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

receiver: Send a single INVALID_MAJOR_VERSION notify for IKE version > 2

Browse Source 
We sent both a notify using IKEv1 and IKEv2. This is a little more aggressive
than required, RFC 5996 says we "SHOULD send an unauthenticated Notify
message of type INVALID_MAJOR_VERSION containing the highest (closest) version
number it supports".

Fixes #657.
This commit is contained in:
Martin Willi
2014-07-17 09:35:49 +02:00
parent 13ec4cf2ad
commit 75122b90bb
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/network/receiver.c
+1 -3
View File
@@ -524,8 +524,7 @@ static job_requeue_t receive_packets(private_receiver_t *this)
#ifdef USE_IKEV2 #ifdef USE_IKEV2
send_notify(message, IKEV2_MAJOR_VERSION, INFORMATIONAL, send_notify(message, IKEV2_MAJOR_VERSION, INFORMATIONAL,
INVALID_MAJOR_VERSION, chunk_empty); INVALID_MAJOR_VERSION, chunk_empty);
#endif /* USE_IKEV2 */ #elif defined(USE_IKEV1)
#ifdef USE_IKEV1
send_notify(message, IKEV1_MAJOR_VERSION, INFORMATIONAL_V1, send_notify(message, IKEV1_MAJOR_VERSION, INFORMATIONAL_V1,
INVALID_MAJOR_VERSION, chunk_empty); INVALID_MAJOR_VERSION, chunk_empty);
#endif /* USE_IKEV1 */ #endif /* USE_IKEV1 */
@@ -684,4 +683,3 @@ receiver_t *receiver_create()
return &this->public; return &this->public;
} }