unit-tests: Fix "using integer constants in boolean context" warning
This warning has been seen in GCC 7.x with -Wall, however, because == has higher precedence than ?: the code was actually not correct.
This commit is contained in:
@@ -108,8 +108,8 @@ START_TEST(test_imcv_seg_env)
|
|||||||
segment = seg_env_attr->get_segment(seg_env_attr, &flags);
|
segment = seg_env_attr->get_segment(seg_env_attr, &flags);
|
||||||
seg = chunk_create(command + n * max_seg_size - 12, seg_size);
|
seg = chunk_create(command + n * max_seg_size - 12, seg_size);
|
||||||
ck_assert(chunk_equals(seg, segment));
|
ck_assert(chunk_equals(seg, segment));
|
||||||
ck_assert(flags == last_seg ? SEG_ENV_FLAG_NONE :
|
ck_assert(flags == (last_seg ? SEG_ENV_FLAG_NONE :
|
||||||
SEG_ENV_FLAG_MORE);
|
SEG_ENV_FLAG_MORE));
|
||||||
}
|
}
|
||||||
|
|
||||||
/* check built segment envelope attribute */
|
/* check built segment envelope attribute */
|
||||||
@@ -137,8 +137,8 @@ START_TEST(test_imcv_seg_env)
|
|||||||
}
|
}
|
||||||
else
|
else
|
||||||
{
|
{
|
||||||
ck_assert(flags == last_seg ? SEG_ENV_FLAG_NONE :
|
ck_assert(flags == (last_seg ? SEG_ENV_FLAG_NONE :
|
||||||
SEG_ENV_FLAG_MORE);
|
SEG_ENV_FLAG_MORE));
|
||||||
seg_env1->add_segment(seg_env1, segment, &error);
|
seg_env1->add_segment(seg_env1, segment, &error);
|
||||||
}
|
}
|
||||||
attr1->destroy(attr1);
|
attr1->destroy(attr1);
|
||||||
|
|||||||
Reference in New Issue
Block a user