denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

load-tester: Fix race condition issuing same SPI

Browse Source 
Due to an unprotected incrementation, two load-tester initiators occasionally
use the same SPI under high load, and hence generate 2 IPsec SAs with the same
identifier. The responder IPsec stack will refuse to configure the second SA.

Use an atomic incrementation to avoid this race condition.

Signed-off-by: Christophe Gouault <[email protected]>
This commit is contained in:
Christophe Gouault
2014-04-24 17:54:15 +02:00
committed by Tobias Brunner
parent 2cbaa63295
commit 7b08063e70
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/plugins/load_tester/load_tester_ipsec.c
+2 -2
View File
@@ -31,14 +31,14 @@ struct private_load_tester_ipsec_t {
/** /**
* faked SPI counter * faked SPI counter
*/ */
u_int32_t spi; refcount_t spi;
}; };
METHOD(kernel_ipsec_t, get_spi, status_t, METHOD(kernel_ipsec_t, get_spi, status_t,
private_load_tester_ipsec_t *this, host_t *src, host_t *dst, private_load_tester_ipsec_t *this, host_t *src, host_t *dst,
u_int8_t protocol, u_int32_t reqid, u_int32_t *spi) u_int8_t protocol, u_int32_t reqid, u_int32_t *spi)
{ {
*spi = ++this->spi; *spi = (uint32_t)ref_get(&this->spi);
return SUCCESS; return SUCCESS;
} }