denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

unit-tests: Don't assert failures for unreadable settings files as root

Browse Source 
The file can still be read by root even if nobody has read privileges.
This commit is contained in:
Tobias Brunner
2014-05-16 17:50:29 +02:00
parent 2145f0c212
commit 7c888e0d23
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libstrongswan/tests/suites/test_settings.c
+8 -5
View File
@@ -675,11 +675,14 @@ START_TEST(test_load_files_section)
ck_assert(!settings->load_files_section(settings, include1".conf", TRUE, "")); ck_assert(!settings->load_files_section(settings, include1".conf", TRUE, ""));
verify_include(); verify_include();
/* unreadable files are too */ /* unreadable files are too (only fails when not running as root) */
ck_assert(chunk_write(contents, include1".no", 0444, TRUE)); if (getuid() != 0)
ck_assert(!settings->load_files_section(settings, include1".no", TRUE, "")); {
unlink(include1".no"); ck_assert(chunk_write(contents, include1".no", 0444, TRUE));
verify_include(); ck_assert(!settings->load_files_section(settings, include1".no", TRUE, ""));
unlink(include1".no");
verify_include();
}
ck_assert(settings->load_files_section(settings, include2, FALSE, "main")); ck_assert(settings->load_files_section(settings, include2, FALSE, "main"));
verify_null("main.key1"); verify_null("main.key1");