From 961cb781b9cceac6ae7667ea5dd657300d5b5cc1 Mon Sep 17 00:00:00 2001 From: Tobias Brunner Date: Fri, 11 Feb 2022 11:55:36 +0100 Subject: [PATCH] plugin-feature: Remove 'default' case in plugin_feature_un|load() --- src/libstrongswan/plugins/plugin_feature.c | 26 ++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/src/libstrongswan/plugins/plugin_feature.c b/src/libstrongswan/plugins/plugin_feature.c index 4b3f0ebb3..0649801e0 100644 --- a/src/libstrongswan/plugins/plugin_feature.c +++ b/src/libstrongswan/plugins/plugin_feature.c @@ -472,6 +472,17 @@ bool plugin_feature_load(plugin_t *plugin, plugin_feature_t *feature, name = plugin->get_name(plugin); switch (feature->type) { + case FEATURE_NONE: + case FEATURE_PRIVKEY_SIGN: + case FEATURE_PRIVKEY_DECRYPT: + case FEATURE_PUBKEY_VERIFY: + case FEATURE_PUBKEY_ENCRYPT: + case FEATURE_EAP_SERVER: + case FEATURE_EAP_PEER: + case FEATURE_XAUTH_SERVER: + case FEATURE_XAUTH_PEER: + case FEATURE_CUSTOM: + break; case FEATURE_CRYPTER: lib->crypto->add_crypter(lib->crypto, feature->arg.crypter.alg, feature->arg.crypter.key_size, @@ -547,8 +558,6 @@ bool plugin_feature_load(plugin_t *plugin, plugin_feature_t *feature, case FEATURE_RESOLVER: lib->resolver->add_resolver(lib->resolver, reg->arg.reg.f); break; - default: - break; } return TRUE; } @@ -574,6 +583,17 @@ bool plugin_feature_unload(plugin_t *plugin, plugin_feature_t *feature, } switch (feature->type) { + case FEATURE_NONE: + case FEATURE_PRIVKEY_SIGN: + case FEATURE_PRIVKEY_DECRYPT: + case FEATURE_PUBKEY_VERIFY: + case FEATURE_PUBKEY_ENCRYPT: + case FEATURE_EAP_SERVER: + case FEATURE_EAP_PEER: + case FEATURE_XAUTH_SERVER: + case FEATURE_XAUTH_PEER: + case FEATURE_CUSTOM: + break; case FEATURE_CRYPTER: lib->crypto->remove_crypter(lib->crypto, reg->arg.reg.f); break; @@ -628,8 +648,6 @@ bool plugin_feature_unload(plugin_t *plugin, plugin_feature_t *feature, case FEATURE_RESOLVER: lib->resolver->remove_resolver(lib->resolver, reg->arg.reg.f); break; - default: - break; } return TRUE; }