openssl: Move ENGINE-specific code into a separate file
This way we can compile it with OPENSSL_SUPPRESS_DEPRECATED for OpenSSL 3.0, which deprecated the ENGINE API.
This commit is contained in:
@@ -25,9 +25,6 @@
|
||||
#include <openssl/conf.h>
|
||||
#include <openssl/rand.h>
|
||||
#include <openssl/crypto.h>
|
||||
#ifndef OPENSSL_NO_ENGINE
|
||||
#include <openssl/engine.h>
|
||||
#endif
|
||||
#ifndef OPENSSL_NO_ECDH
|
||||
#include <openssl/ec.h>
|
||||
#endif
|
||||
@@ -38,6 +35,7 @@
|
||||
#include "openssl_plugin.h"
|
||||
#include "openssl_util.h"
|
||||
#include "openssl_crypter.h"
|
||||
#include "openssl_engine.h"
|
||||
#include "openssl_hasher.h"
|
||||
#include "openssl_sha1_prf.h"
|
||||
#include "openssl_diffie_hellman.h"
|
||||
@@ -316,157 +314,6 @@ static private_key_t *openssl_private_key_load(key_type_t type, va_list args)
|
||||
return NULL;
|
||||
}
|
||||
|
||||
#ifndef OPENSSL_NO_ENGINE
|
||||
/**
|
||||
* Login to engine with a PIN specified for a keyid
|
||||
*/
|
||||
static bool login(ENGINE *engine, chunk_t keyid)
|
||||
{
|
||||
enumerator_t *enumerator;
|
||||
shared_key_t *shared;
|
||||
identification_t *id;
|
||||
chunk_t key;
|
||||
char pin[64];
|
||||
bool found = FALSE, success = FALSE;
|
||||
|
||||
id = identification_create_from_encoding(ID_KEY_ID, keyid);
|
||||
enumerator = lib->credmgr->create_shared_enumerator(lib->credmgr,
|
||||
SHARED_PIN, id, NULL);
|
||||
while (enumerator->enumerate(enumerator, &shared, NULL, NULL))
|
||||
{
|
||||
found = TRUE;
|
||||
key = shared->get_key(shared);
|
||||
if (snprintf(pin, sizeof(pin),
|
||||
"%.*s", (int)key.len, key.ptr) >= sizeof(pin))
|
||||
{
|
||||
continue;
|
||||
}
|
||||
if (ENGINE_ctrl_cmd_string(engine, "PIN", pin, 0))
|
||||
{
|
||||
success = TRUE;
|
||||
break;
|
||||
}
|
||||
else
|
||||
{
|
||||
DBG1(DBG_CFG, "setting PIN on engine failed");
|
||||
}
|
||||
}
|
||||
enumerator->destroy(enumerator);
|
||||
id->destroy(id);
|
||||
if (!found)
|
||||
{
|
||||
DBG1(DBG_CFG, "no PIN found for %#B", &keyid);
|
||||
}
|
||||
return success;
|
||||
}
|
||||
#endif /* OPENSSL_NO_ENGINE */
|
||||
|
||||
/**
|
||||
* Load private key via engine
|
||||
*/
|
||||
static private_key_t *openssl_private_key_connect(key_type_t type,
|
||||
va_list args)
|
||||
{
|
||||
#ifndef OPENSSL_NO_ENGINE
|
||||
char *engine_id = NULL;
|
||||
char keyname[BUF_LEN];
|
||||
chunk_t keyid = chunk_empty;
|
||||
EVP_PKEY *key;
|
||||
ENGINE *engine;
|
||||
int slot = -1;
|
||||
|
||||
while (TRUE)
|
||||
{
|
||||
switch (va_arg(args, builder_part_t))
|
||||
{
|
||||
case BUILD_PKCS11_KEYID:
|
||||
keyid = va_arg(args, chunk_t);
|
||||
continue;
|
||||
case BUILD_PKCS11_SLOT:
|
||||
slot = va_arg(args, int);
|
||||
continue;
|
||||
case BUILD_PKCS11_MODULE:
|
||||
engine_id = va_arg(args, char*);
|
||||
continue;
|
||||
case BUILD_END:
|
||||
break;
|
||||
default:
|
||||
return NULL;
|
||||
}
|
||||
break;
|
||||
}
|
||||
if (!keyid.len)
|
||||
{
|
||||
return NULL;
|
||||
}
|
||||
|
||||
memset(keyname, 0, sizeof(keyname));
|
||||
if (slot != -1)
|
||||
{
|
||||
snprintf(keyname, sizeof(keyname), "%d:", slot);
|
||||
}
|
||||
if (sizeof(keyname) - strlen(keyname) <= keyid.len * 2 + 1)
|
||||
{
|
||||
return NULL;
|
||||
}
|
||||
chunk_to_hex(keyid, keyname + strlen(keyname), FALSE);
|
||||
|
||||
if (!engine_id)
|
||||
{
|
||||
engine_id = lib->settings->get_str(lib->settings,
|
||||
"%s.plugins.openssl.engine_id", "pkcs11", lib->ns);
|
||||
}
|
||||
engine = ENGINE_by_id(engine_id);
|
||||
if (!engine)
|
||||
{
|
||||
DBG2(DBG_LIB, "engine '%s' is not available", engine_id);
|
||||
return NULL;
|
||||
}
|
||||
if (!ENGINE_init(engine))
|
||||
{
|
||||
DBG1(DBG_LIB, "failed to initialize engine '%s'", engine_id);
|
||||
ENGINE_free(engine);
|
||||
return NULL;
|
||||
}
|
||||
ENGINE_free(engine);
|
||||
if (!login(engine, keyid))
|
||||
{
|
||||
DBG1(DBG_LIB, "login to engine '%s' failed", engine_id);
|
||||
ENGINE_finish(engine);
|
||||
return NULL;
|
||||
}
|
||||
key = ENGINE_load_private_key(engine, keyname, NULL, NULL);
|
||||
ENGINE_finish(engine);
|
||||
if (!key)
|
||||
{
|
||||
DBG1(DBG_LIB, "failed to load private key with ID '%s' from "
|
||||
"engine '%s'", keyname, engine_id);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
switch (EVP_PKEY_base_id(key))
|
||||
{
|
||||
#ifndef OPENSSL_NO_RSA
|
||||
case EVP_PKEY_RSA:
|
||||
return openssl_rsa_private_key_create(key, TRUE);
|
||||
#endif
|
||||
#ifndef OPENSSL_NO_ECDSA
|
||||
case EVP_PKEY_EC:
|
||||
return openssl_ec_private_key_create(key, TRUE);
|
||||
#endif
|
||||
#if OPENSSL_VERSION_NUMBER >= 0x1010100fL && !defined(OPENSSL_NO_EC)
|
||||
case EVP_PKEY_ED25519:
|
||||
case EVP_PKEY_ED448:
|
||||
return openssl_ed_private_key_create(key, TRUE);
|
||||
#endif /* OPENSSL_VERSION_NUMBER */
|
||||
default:
|
||||
EVP_PKEY_free(key);
|
||||
break;
|
||||
}
|
||||
#endif /* OPENSSL_NO_ENGINE */
|
||||
return NULL;
|
||||
}
|
||||
|
||||
METHOD(plugin_t, get_name, char*,
|
||||
private_openssl_plugin_t *this)
|
||||
{
|
||||
@@ -865,6 +712,7 @@ METHOD(plugin_t, get_features, int,
|
||||
METHOD(plugin_t, destroy, void,
|
||||
private_openssl_plugin_t *this)
|
||||
{
|
||||
|
||||
/* OpenSSL 1.1.0 cleans up itself at exit and while OPENSSL_cleanup() exists we
|
||||
* can't call it as we couldn't re-initialize the library (as required by the
|
||||
* unit tests and the Android app) */
|
||||
@@ -874,9 +722,7 @@ METHOD(plugin_t, destroy, void,
|
||||
OBJ_cleanup();
|
||||
#endif
|
||||
EVP_cleanup();
|
||||
#ifndef OPENSSL_NO_ENGINE
|
||||
ENGINE_cleanup();
|
||||
#endif /* OPENSSL_NO_ENGINE */
|
||||
openssl_engine_deinit();
|
||||
CRYPTO_cleanup_all_ex_data();
|
||||
threading_cleanup();
|
||||
ERR_free_strings();
|
||||
@@ -960,11 +806,7 @@ plugin_t *openssl_plugin_create()
|
||||
OPENSSL_config(NULL);
|
||||
#endif
|
||||
OpenSSL_add_all_algorithms();
|
||||
#ifndef OPENSSL_NO_ENGINE
|
||||
/* activate support for hardware accelerators */
|
||||
ENGINE_load_builtin_engines();
|
||||
ENGINE_register_all_complete();
|
||||
#endif /* OPENSSL_NO_ENGINE */
|
||||
openssl_engine_init();
|
||||
#endif /* OPENSSL_VERSION_NUMBER */
|
||||
|
||||
#if OPENSSL_VERSION_NUMBER >= 0x30000000L
|
||||
|
||||
Reference in New Issue
Block a user