denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

eap-mschapv2: Fix potential leaks in case of invalid messages from servers

Browse Source
This commit is contained in:
Tobias Brunner
2014-04-09 18:27:02 +02:00
parent f0923ff377
commit abd7d3be9c
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/plugins/eap_mschapv2/eap_mschapv2.c
+4
View File
@@ -792,12 +792,14 @@ static status_t process_peer_success(private_eap_mschapv2_t *this,
"invalid auth string"); "invalid auth string");
goto error; goto error;
} }
chunk_free(&auth_string);
hex = chunk_create(token, AUTH_RESPONSE_LEN - 2); hex = chunk_create(token, AUTH_RESPONSE_LEN - 2);
auth_string = chunk_from_hex(hex, NULL); auth_string = chunk_from_hex(hex, NULL);
} }
else if (strpfx(token, "M=")) else if (strpfx(token, "M="))
{ {
token += 2; token += 2;
free(msg);
msg = strdup(token); msg = strdup(token);
} }
} }
@@ -883,6 +885,7 @@ static status_t process_peer_failure(private_eap_mschapv2_t *this,
"invalid challenge"); "invalid challenge");
goto error; goto error;
} }
chunk_free(&challenge);
hex = chunk_create(token, 2 * CHALLENGE_LEN); hex = chunk_create(token, 2 * CHALLENGE_LEN);
challenge = chunk_from_hex(hex, NULL); challenge = chunk_from_hex(hex, NULL);
} }
@@ -893,6 +896,7 @@ static status_t process_peer_failure(private_eap_mschapv2_t *this,
else if (strpfx(token, "M=")) else if (strpfx(token, "M="))
{ {
token += 2; token += 2;
free(msg);
msg = strdup(token); msg = strdup(token);
} }
} }