compare certificates against full encoding to allow equality check of untrusted certs

src/libstrongswan/plugins/x509/x509_ocsp_request.c

@@ -424,6 +424,9 @@ static chunk_t get_encoding(private_x509_ocsp_request_t *this)
  */
 static bool equals(private_x509_ocsp_request_t *this, certificate_t *other)
 {
+	chunk_t encoding;
+	bool equal;
+	
 	if (this == (private_x509_ocsp_request_t*)other)
 	{
 		return TRUE;
@@ -432,14 +435,14 @@ static bool equals(private_x509_ocsp_request_t *this, certificate_t *other)
 	{
 		return FALSE;
 	}
-	/* check if we have the same X509 implementation */
 	if (other->equals == (void*)equals)
-	{
-		return chunk_equals(this->encoding, 
-							((private_x509_ocsp_request_t*)other)->encoding); 
+	{	/* skip allocation if we have the same implementation */
+		return chunk_equals(this->encoding, ((private_x509_ocsp_request_t*)other)->encoding); 
 	}
-	/* TODO: compare against other implementation */
-	return FALSE;
+	encoding = other->get_encoding(other);
+	equal = chunk_equals(this->encoding, encoding);
+	free(encoding.ptr);
+	return equal;
 }
 
 /**