denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

child-create: Retry creating the CHILD_SA if TEMPORARY_FAILURE is received

Browse Source 
We queue a delayed task that is initiated after a while.
This commit is contained in:
Tobias Brunner
2016-06-17 18:48:07 +02:00
parent 208678e6e1
commit b92f11c3bd
1 changed files with 33 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/sa/ikev2/tasks/child_create.c
+33 -4
View File
@@ -1,8 +1,8 @@
/* /*
* Copyright (C) 2008 Tobias Brunner * Copyright (C) 2008-2016 Tobias Brunner
* Copyright (C) 2005-2008 Martin Willi * Copyright (C) 2005-2008 Martin Willi
* Copyright (C) 2005 Jan Hutter * Copyright (C) 2005 Jan Hutter
* Hochschule fuer Technik Rapperswil * HSR Hochschule fuer Technik Rapperswil
* *
* This program is free software; you can redistribute it and/or modify it * This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the * under the terms of the GNU General Public License as published by the
@@ -29,7 +29,7 @@
#include <encoding/payloads/delete_payload.h> #include <encoding/payloads/delete_payload.h>
#include <processing/jobs/delete_ike_sa_job.h> #include <processing/jobs/delete_ike_sa_job.h>
#include <processing/jobs/inactivity_job.h> #include <processing/jobs/inactivity_job.h>
#include <processing/jobs/initiate_tasks_job.h>
typedef struct private_child_create_t private_child_create_t; typedef struct private_child_create_t private_child_create_t;
@@ -204,6 +204,25 @@ struct private_child_create_t {
bool retry; bool retry;
}; };
/**
* Schedule a retry if creating the CHILD_SA temporary failed
*/
static void schedule_delayed_retry(private_child_create_t *this)
{
child_create_t *task;
uint32_t retry;
retry = RETRY_INTERVAL - (random() % RETRY_JITTER);
task = child_create_create(this->ike_sa,
this->config->get_ref(this->config), FALSE,
this->packet_tsi, this->packet_tsr);
task->use_reqid(task, this->reqid);
DBG1(DBG_IKE, "creating CHILD_SA failed, trying again in %d seconds",
retry);
this->ike_sa->queue_task_delayed(this->ike_sa, (task_t*)task, retry);
}
/** /**
* get the nonce from a message * get the nonce from a message
*/ */
@@ -1434,7 +1453,6 @@ METHOD(task_t, process_i, status_t,
case FAILED_CP_REQUIRED: case FAILED_CP_REQUIRED:
case TS_UNACCEPTABLE: case TS_UNACCEPTABLE:
case INVALID_SELECTORS: case INVALID_SELECTORS:
case TEMPORARY_FAILURE:
{ {
DBG1(DBG_IKE, "received %N notify, no CHILD_SA built", DBG1(DBG_IKE, "received %N notify, no CHILD_SA built",
notify_type_names, type); notify_type_names, type);
@@ -1444,6 +1462,17 @@ METHOD(task_t, process_i, status_t,
/* an error in CHILD_SA creation is not critical */ /* an error in CHILD_SA creation is not critical */
return SUCCESS; return SUCCESS;
} }
case TEMPORARY_FAILURE:
{
DBG1(DBG_IKE, "received %N notify, will retry later",
notify_type_names, type);
enumerator->destroy(enumerator);
if (!this->rekey)
{ /* the rekey task will retry itself if necessary */
schedule_delayed_retry(this);
}
return SUCCESS;
}
case INVALID_KE_PAYLOAD: case INVALID_KE_PAYLOAD:
{ {
chunk_t data; chunk_t data;