keychain: load certificates only once during startup, improving performance

src/libstrongswan/plugins/keychain/keychain_creds.c

@@ -16,6 +16,7 @@
 #include "keychain_creds.h"
 
 #include <utils/debug.h>
+#include <credentials/sets/mem_cred.h>
 
 #include <Security/Security.h>
 
@@ -30,87 +31,22 @@ struct private_keychain_creds_t {
 	 * Public keychain_creds_t interface.
 	 */
 	keychain_creds_t public;
+
+	/**
+	 * Active in-memory credential set
+	 */
+	mem_cred_t *set;
 };
 
 /**
- * Enumerator for certificates
+ * Create a credential set loaded with certificates
  */
-typedef struct {
+static mem_cred_t* load_creds(private_keychain_creds_t *this)
-	/* implements enumerator_t */
-	enumerator_t public;
-	/* currently enumerating certificate */
-	certificate_t *current;
-	/* id to filter for */
-	identification_t *id;
-	/* certificate public key type we are looking for */
-	key_type_t type;
-	/* array of binary certificates to enumerate */
-	CFArrayRef certs;
-	/* current position in array */
-	int i;
-} cert_enumerator_t;
-
-METHOD(enumerator_t, enumerate_certs, bool,
-	cert_enumerator_t *this, certificate_t **out)
 {
-	DESTROY_IF(this->current);
+	mem_cred_t *set;
-	this->current = NULL;
-
-	while (this->i < CFArrayGetCount(this->certs))
-	{
-		certificate_t *cert;
-		public_key_t *key;
-		CFDataRef data;
-		chunk_t chunk;
-
-		data = CFArrayGetValueAtIndex(this->certs, this->i++);
-		if (data)
-		{
-			chunk = chunk_create((char*)CFDataGetBytePtr(data),
-								 CFDataGetLength(data));
-			cert = lib->creds->create(lib->creds, CRED_CERTIFICATE, CERT_X509,
-									  BUILD_BLOB_ASN1_DER, chunk, BUILD_END);
-			if (cert)
-			{
-				if (!this->id || cert->has_subject(cert, this->id))
-				{
-					key = cert->get_public_key(cert);
-					if (key)
-					{
-						if (this->type == KEY_ANY ||
-							this->type == key->get_type(key))
-						{
-							key->destroy(key);
-							this->current = cert;
-							*out = cert;
-							return TRUE;
-						}
-						key->destroy(key);
-					}
-				}
-				cert->destroy(cert);
-			}
-		}
-	}
-	return FALSE;
-}
-
-METHOD(enumerator_t, destroy_certs, void,
-	cert_enumerator_t *this)
-{
-	DESTROY_IF(this->current);
-	CFRelease(this->certs);
-	free(this);
-}
-
-METHOD(credential_set_t, create_cert_enumerator, enumerator_t*,
-	private_keychain_creds_t *this, certificate_type_t cert, key_type_t key,
-	identification_t *id, bool trusted)
-{
-	cert_enumerator_t *enumerator;
 	OSStatus status;
 	CFDictionaryRef query;
-	CFArrayRef result;
+	CFArrayRef certs;
 	const void* keys[] = {
 		kSecReturnData,
 		kSecMatchLimit,
@@ -123,39 +59,54 @@ METHOD(credential_set_t, create_cert_enumerator, enumerator_t*,
 		kSecMatchLimitAll,
 		kSecClassCertificate,
 		kCFBooleanTrue,
-		trusted ? kCFBooleanTrue : kCFBooleanFalse,
+		kCFBooleanTrue,
 	};
+	int i;
 
-	if (cert == CERT_ANY || cert == CERT_X509)
+	set = mem_cred_create();
+
+	DBG1(DBG_CFG, "loading System certificates:");
+	query = CFDictionaryCreate(NULL, keys, values, countof(keys),
+							   &kCFTypeDictionaryKeyCallBacks,
+							   &kCFTypeDictionaryValueCallBacks);
+	if (query)
 	{
-		query = CFDictionaryCreate(NULL, keys, values, countof(keys),
+		status = SecItemCopyMatching(query, (CFTypeRef*)&certs);
-								   &kCFTypeDictionaryKeyCallBacks,
+		CFRelease(query);
-								   &kCFTypeDictionaryValueCallBacks);
+		if (status == errSecSuccess)
-		if (query)
 		{
-			status = SecItemCopyMatching(query, (CFTypeRef*)&result);
+			for (i = 0; i < CFArrayGetCount(certs); i++)
-			CFRelease(query);
-			if (status == errSecSuccess)
 			{
-				INIT(enumerator,
+				certificate_t *cert;
-					.public = {
+				CFDataRef data;
-						.enumerate = (void*)_enumerate_certs,
+				chunk_t chunk;
-						.destroy = _destroy_certs,
+
-					},
+				data = CFArrayGetValueAtIndex(certs, i);
-					.certs = result,
+				if (data)
-					.id = id,
+				{
-					.type = key,
+					chunk = chunk_create((char*)CFDataGetBytePtr(data),
-				);
+										 CFDataGetLength(data));
-				return &enumerator->public;
+					cert = lib->creds->create(lib->creds,
+										CRED_CERTIFICATE, CERT_X509,
+										BUILD_BLOB_ASN1_DER, chunk, BUILD_END);
+					if (cert)
+					{
+						DBG1(DBG_CFG, "  loaded '%Y'", cert->get_subject(cert));
+						set->add_cert(set, TRUE, cert);
+					}
+				}
 			}
+			CFRelease(certs);
 		}
 	}
-	return enumerator_create_empty();
+	return set;
 }
 
 METHOD(keychain_creds_t, destroy, void,
 	private_keychain_creds_t *this)
 {
+	lib->credmgr->remove_set(lib->credmgr, &this->set->set);
+	this->set->destroy(this->set);
 	free(this);
 }
 
@@ -168,16 +119,12 @@ keychain_creds_t *keychain_creds_create()
 
 	INIT(this,
 		.public = {
-			.set = {
-				.create_shared_enumerator = (void*)enumerator_create_empty,
-				.create_private_enumerator = (void*)enumerator_create_empty,
-				.create_cert_enumerator = _create_cert_enumerator,
-				.create_cdp_enumerator  = (void*)enumerator_create_empty,
-				.cache_cert = (void*)nop,
-			},
 			.destroy = _destroy,
 		},
 	);
 
+	this->set = load_creds(this);
+	lib->credmgr->add_set(lib->credmgr, &this->set->set);
+
 	return &this->public;
 }

src/libstrongswan/plugins/keychain/keychain_creds.h

@@ -30,11 +30,6 @@ typedef struct keychain_creds_t keychain_creds_t;
  */
 struct keychain_creds_t {
 
-	/**
-	 * Implements credential_set_t.
-	 */
-	credential_set_t set;
-
 	/**
 	 * Destroy a keychain_creds_t.
 	 */

src/libstrongswan/plugins/keychain/keychain_plugin.c

@@ -42,11 +42,38 @@ METHOD(plugin_t, get_name, char*,
 	return "keychain";
 }
 
+/**
+ * Load/unload certificates from Keychain.
+ */
+static bool load_creds(private_keychain_plugin_t *this,
+					   plugin_feature_t *feature, bool reg, void *data)
+{
+	if (reg)
+	{
+		this->creds = keychain_creds_create();
+	}
+	else
+	{
+		this->creds->destroy(this->creds);
+	}
+	return TRUE;
+}
+
+METHOD(plugin_t, get_features, int,
+	private_keychain_plugin_t *this, plugin_feature_t *features[])
+{
+	static plugin_feature_t f[] = {
+		PLUGIN_CALLBACK((plugin_feature_callback_t)load_creds, NULL),
+			PLUGIN_PROVIDE(CUSTOM, "keychain"),
+				PLUGIN_DEPENDS(CERT_DECODE, CERT_X509),
+	};
+	*features = f;
+	return countof(f);
+}
+
 METHOD(plugin_t, destroy, void,
 	private_keychain_plugin_t *this)
 {
-	lib->credmgr->remove_set(lib->credmgr, &this->creds->set);
-	this->creds->destroy(this->creds);
 	free(this);
 }
 
@@ -61,13 +88,11 @@ plugin_t *keychain_plugin_create()
 		.public = {
 			.plugin = {
 				.get_name = _get_name,
+				.get_features = _get_features,
 				.destroy = _destroy,
 			},
 		},
-		.creds = keychain_creds_create(),
 	);
 
-	lib->credmgr->add_set(lib->credmgr, &this->creds->set);
-
 	return &this->public.plugin;
 }