denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Change order of destroy/get_ref function calls

Browse Source 
Since DESTROY_IF might destroy the peer_cfg, a get_ref on a freed object
is subject to fail.
This commit is contained in:
Thomas Egerer
2011-11-04 11:11:17 +01:00
committed by Tobias Brunner
parent c230885a07
commit dbd2169569
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcharon/sa/ike_sa.c
+1 -1
View File
@@ -349,8 +349,8 @@ METHOD(ike_sa_t, get_peer_cfg, peer_cfg_t*,
METHOD(ike_sa_t, set_peer_cfg, void, METHOD(ike_sa_t, set_peer_cfg, void,
private_ike_sa_t *this, peer_cfg_t *peer_cfg) private_ike_sa_t *this, peer_cfg_t *peer_cfg)
{ {
DESTROY_IF(this->peer_cfg);
peer_cfg->get_ref(peer_cfg); peer_cfg->get_ref(peer_cfg);
DESTROY_IF(this->peer_cfg);
this->peer_cfg = peer_cfg; this->peer_cfg = peer_cfg;
if (this->ike_cfg == NULL) if (this->ike_cfg == NULL)