denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't use chunk_skip() in asn1_length().

Browse Source 
chunk_skip() returns chunk_empty if the length of the chunk is equal to
the number of bytes to skip, this is problematic as asn1_length() modifies
the original chunk.  asn1_parser_t for instance uses the modified chunk to
later calculate the length of the resulting ASN.1 object which produces
incorrect results if it is based on chunk_empty.
This commit is contained in:
Tobias Brunner
2012-06-11 17:09:20 +02:00
parent 6e6d78a561
commit e8120632ae
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libstrongswan/asn1/asn1.c
+2 -1
View File
@@ -228,7 +228,8 @@ size_t asn1_length(chunk_t *blob)
/* read length field, skip tag and length */ /* read length field, skip tag and length */
n = blob->ptr[1]; n = blob->ptr[1];
*blob = chunk_skip(*blob, 2); blob->ptr += 2;
blob->len -= 2;
if ((n & 0x80) == 0) if ((n & 0x80) == 0)
{ /* single length octet */ { /* single length octet */