denozord/strongswan-ext
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fixed a memory leak in OCSP fetching

Browse Source
This commit is contained in:
Andreas Steffen
2009-10-29 10:00:19 +01:00
parent 140816b055
commit f893bce3e7
1 changed files with 14 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/pluto/ocsp.c
+14 -3
View File
@@ -1466,6 +1466,14 @@ static void process_single_response(ocsp_location_t *location,
free_certinfo(certinfo); free_certinfo(certinfo);
} }
/**
* Destroy a response_t object
*/
static void free_response(response_t *res)
{
DESTROY_IF(res->responder_id_name);
}
/** /**
* Parse and verify ocsp response and update the ocsp cache * Parse and verify ocsp response and update the ocsp cache
*/ */
@@ -1479,7 +1487,7 @@ void parse_ocsp(ocsp_location_t *location, chunk_t blob)
if (status != STATUS_SUCCESSFUL) if (status != STATUS_SUCCESSFUL)
{ {
plog("error in ocsp response"); plog("error in ocsp response");
return; goto free;
} }
/* check if there was a nonce in the request */ /* check if there was a nonce in the request */
if (location->nonce.ptr && res.nonce.ptr == NULL) if (location->nonce.ptr && res.nonce.ptr == NULL)
@@ -1490,13 +1498,13 @@ void parse_ocsp(ocsp_location_t *location, chunk_t blob)
if (res.nonce.ptr && !chunk_equals(res.nonce, location->nonce)) if (res.nonce.ptr && !chunk_equals(res.nonce, location->nonce))
{ {
plog("invalid nonce in ocsp response"); plog("invalid nonce in ocsp response");
return; goto free;
} }
/* check if the response is signed by a trusted key */ /* check if the response is signed by a trusted key */
if (!valid_ocsp_response(&res)) if (!valid_ocsp_response(&res))
{ {
plog("invalid ocsp response"); plog("invalid ocsp response");
return; goto free;
} }
DBG(DBG_CONTROL, DBG(DBG_CONTROL,
DBG_log("valid ocsp response") DBG_log("valid ocsp response")
@@ -1527,4 +1535,7 @@ void parse_ocsp(ocsp_location_t *location, chunk_t blob)
end: end:
parser->destroy(parser); parser->destroy(parser);
} }
free:
free_response(&res);
} }