Tobias Brunner
432e2a72b2
settings: Clarify that a key/value-pair can only occur once
2018-09-17 18:51:43 +02:00
Tobias Brunner
c07dde4b7d
vici: Fix syntax error in Ruby bindings
...
I guess nobody uses these.
Fixes: 2c7cfe7630 ("vici: flush-certs command flushes certificate cache")
2018-09-17 18:51:43 +02:00
Tobias Brunner
f1889ca34a
imv-attestation: Don't use comma to separate statements
2018-09-17 18:51:43 +02:00
Tobias Brunner
f0d34f32a7
imv-agent: Don't use comma to separate statements
2018-09-17 18:51:43 +02:00
Tobias Brunner
52b6506a23
xauth-pam: Don't use comma to separate statements
2018-09-17 18:51:42 +02:00
Tobias Brunner
2c41fb6349
tnc-pdp: Don't use comma to separate statements
2018-09-17 18:51:42 +02:00
Tobias Brunner
bea10205b0
receiver: Don't use commas to separate statements
...
Maybe was in the INIT statement at some point.
2018-09-17 18:51:42 +02:00
Tobias Brunner
3552bba63a
manager: Restore direct return if database URI is not defined
...
There was an exit anyway because storage_create() returns NULL if the
database can't be created.
2018-09-17 18:51:42 +02:00
Tobias Brunner
1295558ab3
imv-os-agent: Remove useless assignment
...
`eval` will never be TNC_IMV_EVALUATION_RESULT_DONT_KNOW so we can
remove the if statement too.
2018-09-17 18:51:42 +02:00
Tobias Brunner
ddc797686f
pts: Remove commented call of inexistent function
2018-09-17 18:51:42 +02:00
Tobias Brunner
0b8d00adaf
counters: Fix exit status in error case
2018-09-17 18:51:42 +02:00
Tobias Brunner
66aca84eba
signcrl: Remove useless assignment
2018-09-17 18:51:41 +02:00
Tobias Brunner
020045f416
asn1: Remove useless assignment
2018-09-17 18:51:41 +02:00
Tobias Brunner
3ea33d15a2
mode-config: Remove useless assignment
2018-09-17 18:51:41 +02:00
Tobias Brunner
c503eec92e
keymat_v1: Remove useless assignment
2018-09-17 18:51:41 +02:00
Tobias Brunner
0af96ad5e7
kernel-netlink: Check return value of both halfs when installing default route in main table
2018-09-17 18:51:41 +02:00
Tobias Brunner
d51a28bd5c
botan: Fix leak if hasher initialization fails
2018-09-17 18:51:41 +02:00
Tobias Brunner
dc09570a12
botan: Share code to generate RSA EMSA PSS signature identifier strings
2018-09-17 18:51:40 +02:00
Tobias Brunner
2788529827
botan: Remove unnecessary nested blocks and simplify keyid allocation
2018-09-17 16:41:19 +02:00
Tobias Brunner
7855ad4c9e
daemon: Remove redundant assignment to time_format
2018-09-17 16:41:18 +02:00
Tobias Brunner
a80069e7bf
gcrypt: Make generic DH constructor static
2018-09-12 16:25:00 +02:00
Tobias Brunner
b4062c4bb7
botan: Add support for X25519
2018-09-12 16:25:00 +02:00
Tobias Brunner
40b3bf6ba7
botan: Simplify DH/ECDH key derivation
2018-09-12 16:25:00 +02:00
Tobias Brunner
125222dca7
test-vectors: Add the actual test vector from RFC 8031 for x25519
...
The existing test vector is from RFC 8037.
2018-09-12 16:25:00 +02:00
Tobias Brunner
e5e500c07e
ike-init: Fix leak if KE payload creation fails
2018-09-12 16:25:00 +02:00
Tobias Brunner
472efd3809
leak-detective: Add an option to ignore frees of unknown memory blocks
...
This also changes how unknown/corrupted memory is handled in the free()
and realloc() hooks in general.
Incorporates changes provided by Thomas Egerer who ran into a similar
issue.
2018-09-12 16:25:00 +02:00
Tobias Brunner
c064a5288e
leak-detective: Whitelist some Botan functions
...
Due to the mangled C++ function names it's tricky to be more specific. The
"leaked" allocations are from a static hashtable containing EC groups.
There is another leak caused by the locking allocator singleton
(triggered by the first function that uses it, usually initialization of
a cipher, but could be a hasher in other test runners), but we can avoid
that with a Botan config option.
2018-09-12 16:25:00 +02:00
Tobias Brunner
304d4ca57a
botan: Adhere to configured DH exponent length
2018-09-12 16:25:00 +02:00
Tobias Brunner
bd267c863f
botan: Encode private keys as PKCS#8
...
Since we can now parse that encoding directly we can simplify the private
key export and stick to PKCS#8.
2018-09-12 16:25:00 +02:00
Tobias Brunner
607f10dca4
botan: Load public/private keys generically
...
Simplifies public key loading and this way unencrypted PKCS#8-encoded
keys can be loaded directly without pkcs8 plugin (code for encrypted
keys could probably later be added, if necessary).
It also simplifies the implementation of private_key_t::get_public_key()
a lot.
2018-09-12 16:25:00 +02:00
Tobias Brunner
72491b7843
botan: Encode curve OID and public key in EC private key
...
Without OID we can't generate an algorithmIdentifier when loading the
key again. And older versions of OpenSSL insist on a public key when
e.g. converting a key to PKCS#8.
Simply unwrapping the ECPrivateKey structure avoids log messages when
parsing other keys in the KEY_ANY case.
2018-09-12 16:25:00 +02:00
Tobias Brunner
ba7e74291e
pkcs1: Accept EC private keys without public key but make sure of an OID
2018-09-12 16:25:00 +02:00
Tobias Brunner
de2a24310c
botan: Fixes, code style changes plus some refactorings
...
Some changes rely on newly added FFI functions in Botan's master
branch.
2018-09-12 16:25:00 +02:00
René Korthaus
13f113f7a9
botan: Add MD5 support to Botan hasher
...
Support MD5 in the Botan plugin if supported by Botan.
MD5 is required for RADIUS and obviously EAP-MD5,
and also for non-PKCS#8 encoded, encrypted private keys.
2018-09-12 16:25:00 +02:00
René Korthaus
04ecaff6a9
unit-tests: Remove 768 bits RSA gen test
...
Botan only allows RSA generating keys >= 1,024 bits, which makes
the RSA test suite fail. It is questionable whether it makes
sense to test 768 bit RSA keys anymore. They are too weak
from today's perspective anyway.
2018-09-12 16:25:00 +02:00
René Korthaus
af26cc4d85
botan: Add Botan plugin to libstrongswan
2018-09-12 16:25:00 +02:00
Tobias Brunner
66c4735f99
dumm: Remove the Dynamic UML Mesh Modeler framework
...
This has been pretty much defunct for several years (requires a
specially patched UML-enabled guest kernel).
2018-09-12 15:53:55 +02:00
Tobias Brunner
948c42ab2e
android: Properly set log file path
2018-09-12 11:44:57 +02:00
Tobias Brunner
f6b4ba2a65
library: Return FALSE from library_init() if loaded settings are invalid
...
This way daemons won't start with config files that contain errors.
2018-09-11 18:30:18 +02:00
Tobias Brunner
71dca60c31
settings: Don't allow dots in section/key names anymore
...
This requires config changes if filelog is used with a path that
contains dots. This path must now be defined in the `path` setting of an
arbitrarily named subsection of `filelog`. Without that change the
whole strongswan.conf file will fail to load, which some users might
not notice immediately.
2018-09-11 18:30:18 +02:00
Tobias Brunner
85afe81e1f
ike-auth: Remove unnecessary case statement
2018-09-11 18:18:50 +02:00
Tobias Brunner
a0c302f878
vici: Remove unreachable code
...
If list is TRUE any type but VICI_LIST_END and VICI_LIST_ITEM (i.e.
including VICI_END) is already handled in the first block in this
function.
2018-09-11 18:18:50 +02:00
Tobias Brunner
954e75effa
vici: Lease enumerator is always defined
...
mem_pool_t always returns an enumerator.
2018-09-11 18:18:50 +02:00
Tobias Brunner
55fb268b51
stroke: Lease enumerator is always defined
...
This function is only called for existing pools (under the protection of
a read lock).
2018-09-11 18:18:50 +02:00
Tobias Brunner
648709b392
smp: Remove unreachable initializer
...
Execution in this block will start with any of the case statements,
never with the initialization.
2018-09-11 18:18:49 +02:00
Tobias Brunner
23d756e4f0
eap-sim-pcsc: Fix leak in error case
2018-09-11 18:18:49 +02:00
Tobias Brunner
80e8845d36
swanctl: Allow passing a custom config file for each --load* command
...
Mainly for debugging, but could also be used to e.g. use a separate file
for connections and secrets.
2018-09-11 18:14:45 +02:00
Tobias Brunner
755985867e
swanctl: Report the use of a PPK in --list-sas
...
If we later decide the PPK_ID would be helpful, printing this on a
separate line would probably make sense.
2018-09-10 18:03:30 +02:00
Tobias Brunner
c4d2fdd915
vici: Return PPK state of an IKE_SA
2018-09-10 18:03:27 +02:00
Tobias Brunner
e4d85011e4
ikev2: Mark IKE_SAs that used PPK during authentication
2018-09-10 18:03:18 +02:00