ike-sa: Remove redundant setting of IKE_SA conditions after a rekeying

This was originally added with b0e40caafb ("NAT-T conditions were not
inherited during IKE_SA rekeying") in 2008 when there was only a single
inherit() method.  Later the inherit_pre() method was added and then
with 094963d1b1 ("ikev2: Apply extensions and conditions before
starting rekeying") in 2014 the extensions and conditions were set
already there.

src/libcharon/sa/ike_sa.c

@@ -3005,8 +3005,6 @@ METHOD(ike_sa_t, inherit_post, void,
 		array_insert(this->attributes, ARRAY_TAIL, &entry);
 	}
 
-	/* inherit all conditions */
-	this->conditions = other->conditions;
 	if (this->conditions & COND_NAT_HERE)
 	{
 		send_keepalive(this, FALSE);