attr-sql: Use plugin features with dependency to database backend

This commit is contained in:
Tobias Brunner
2013-06-11 11:18:17 +02:00
parent 8a6cc1e35f
commit 989ec772b5
+53 -24
View File
@@ -1,4 +1,5 @@
/*
* Copyright (C) 2013 Tobias Brunner
* Copyright (C) 2008 Martin Willi
* Hochschule fuer Technik Rapperswil
*
@@ -15,6 +16,7 @@
#include <hydra.h>
#include <utils/debug.h>
#include <plugins/plugin_feature.h>
#include "attr_sql_plugin.h"
#include "sql_attribute.h"
@@ -48,12 +50,59 @@ METHOD(plugin_t, get_name, char*,
return "attr-sql";
}
/**
* Connect to database
*/
static bool open_database(private_attr_sql_plugin_t *this,
plugin_feature_t *feature, bool reg, void *cb_data)
{
if (reg)
{
char *uri;
uri = lib->settings->get_str(lib->settings,
"libhydra.plugins.attr-sql.database", NULL);
if (!uri)
{
DBG1(DBG_CFG, "attr-sql plugin: database URI not set");
return FALSE;
}
this->db = lib->db->create(lib->db, uri);
if (!this->db)
{
DBG1(DBG_CFG, "attr-sql plugin failed to connect to database");
return FALSE;
}
this->attribute = sql_attribute_create(this->db);
hydra->attributes->add_provider(hydra->attributes,
&this->attribute->provider);
}
else
{
hydra->attributes->remove_provider(hydra->attributes,
&this->attribute->provider);
this->attribute->destroy(this->attribute);
this->db->destroy(this->db);
}
return TRUE;
}
METHOD(plugin_t, get_features, int,
private_attr_sql_plugin_t *this, plugin_feature_t *features[])
{
static plugin_feature_t f[] = {
PLUGIN_CALLBACK((plugin_feature_callback_t)open_database, NULL),
PLUGIN_PROVIDE(CUSTOM, "attr-sql"),
PLUGIN_DEPENDS(DATABASE, DB_ANY),
};
*features = f;
return countof(f);
}
METHOD(plugin_t, destroy, void,
private_attr_sql_plugin_t *this)
{
hydra->attributes->remove_provider(hydra->attributes, &this->attribute->provider);
this->attribute->destroy(this->attribute);
this->db->destroy(this->db);
free(this);
}
@@ -63,36 +112,16 @@ METHOD(plugin_t, destroy, void,
plugin_t *attr_sql_plugin_create()
{
private_attr_sql_plugin_t *this;
char *uri;
uri = lib->settings->get_str(lib->settings, "libhydra.plugins.attr-sql.database",
NULL);
if (!uri)
{
DBG1(DBG_CFG, "attr-sql plugin: database URI not set");
return NULL;
}
INIT(this,
.public = {
.plugin = {
.get_name = _get_name,
.reload = (void*)return_false,
.get_features = _get_features,
.destroy = _destroy,
},
},
.db = lib->db->create(lib->db, uri),
);
if (!this->db)
{
DBG1(DBG_CFG, "attr-sql plugin failed to connect to database");
free(this);
return NULL;
}
this->attribute = sql_attribute_create(this->db);
hydra->attributes->add_provider(hydra->attributes, &this->attribute->provider);
return &this->public.plugin;
}